Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix TERRASCOPE_S1_SLC_COHERENCE_V1 collection test #297

Closed
bossie opened this issue May 29, 2024 · 3 comments
Closed

fix TERRASCOPE_S1_SLC_COHERENCE_V1 collection test #297

bossie opened this issue May 29, 2024 · 3 comments
Assignees

Comments

@bossie
Copy link
Collaborator

bossie commented May 29, 2024

Terrascope collection test openeo-collection-tests.test_layers.test_layer[TERRASCOPE_S1_SLC_COHERENCE_V1-2020-03-01-2020-04-01] has been failing for some time:

AssertionError: DataFrame.iloc[:, 88] (column name="(44, 0)") are different

DataFrame.iloc[:, 88] (column name="(44, 0)") values are different (10.0 %)
[index]: [2020-03-01T00:00:00Z, 2020-03-02T00:00:00Z, 2020-03-03T00:00:00Z, 2020-03-04T00:00:00Z, 2020-03-05T00:00:00Z, 2020-03-06T00:00:00Z, 2020-03-07T00:00:00Z, 2020-03-08T00:00:00Z, 2020-03-09T00:00:00Z, 2020-03-10T00:00:00Z, 2020-03-11T00:00:00Z, 2020-03-12T00:00:00Z, 2020-03-13T00:00:00Z, 2020-03-14T00:00:00Z, 2020-03-15T00:00:00Z, 2020-03-16T00:00:00Z, 2020-03-17T00:00:00Z, 2020-03-18T00:00:00Z, 2020-03-19T00:00:00Z, 2020-03-20T00:00:00Z, 2020-03-21T00:00:00Z, 2020-03-22T00:00:00Z, 2020-03-23T00:00:00Z, 2020-03-24T00:00:00Z, 2020-03-25T00:00:00Z, 2020-03-27T00:00:00Z, 2020-03-28T00:00:00Z, 2020-03-29T00:00:00Z, 2020-03-30T00:00:00Z, 2020-03-31T00:00:00Z]
[left]:  [nan, nan, nan, nan, nan, 73.6774193548387, nan, nan, 63.32258064516129, nan, nan, 84.61290322580645, nan, nan, nan, nan, nan, 79.16129032258064, nan, nan, 71.48387096774194, nan, nan, 81.0, nan, nan, nan, nan, 117.80645161290325, nan]
[right]: [nan, nan, 75.35483870967742, nan, nan, 73.6774193548387, nan, nan, 63.32258064516129, nan, nan, 84.61290322580645, nan, nan, 98.35483870967742, nan, nan, 79.16129032258064, nan, nan, 71.48387096774194, nan, nan, 81.0, nan, 97.09677419354838, nan, nan, 117.80645161290325, nan]
At positional index 2, first diff: nan != 75.35483870967742

It's not a matter of changed input data because running this test against prod and dev succeeds.

@bossie bossie self-assigned this May 29, 2024
@bossie
Copy link
Collaborator Author

bossie commented May 29, 2024

I tracked down the difference in behavior to commit 6ff3ba7 in the context of #280.

Looks like the change is for the better* so I'm just going to update the reference data.

  • the majority of the values remained exactly the same;
  • some nulls turned into actual values.

FYI @EmileSonneveld

@EmileSonneveld
Copy link
Contributor

This made me reailise it needs to be added to the changelog: Open-EO/openeo-geopyspark-driver@2fccdf6

@bossie
Copy link
Collaborator Author

bossie commented May 30, 2024

The test passes again.

@bossie bossie closed this as completed May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants