Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vector_to_random_points: Change default value of geometry_count to null? #344

Closed
m-mohr opened this issue Mar 15, 2022 · 0 comments · Fixed by #352
Closed

vector_to_random_points: Change default value of geometry_count to null? #344

m-mohr opened this issue Mar 15, 2022 · 0 comments · Fixed by #352
Assignees
Labels
Milestone

Comments

@m-mohr
Copy link
Member

m-mohr commented Mar 15, 2022

For full context see: #315 (comment)

In the end, @soxofaan wrote:

[...] I think there are two concerns I want to tackle simultaneously:

  • giving geom_count=null and total_count=null currently causes CountsMissing error. I think we should provide a non-error behavior (e.g. 1 sample per geometry)
  • if the user just want to specify total_count=100, they should not forget to also explicitly set geom_count to null otherwise it won't work and they just get 1 sample per geometry (because that is the default for geom_count). I don't like this UI/UX-wise.

My proposal to tackle both is:

  • give geom_count default value null
  • allow geom_count=null + total_count=null : 1 sample per geometry

Achieving the latter can be done (instead of the "dynamic" total_count default value trick I suggested earlier) by replacing the note about CountsMissing with something like:

If geometry_count and total_count are both unrestricted (i.e. set to null), one sample per geometry is used.

@m-mohr m-mohr added the vector label Mar 15, 2022
@m-mohr m-mohr added this to the 1.3.0 milestone Mar 15, 2022
@m-mohr m-mohr self-assigned this Mar 20, 2022
m-mohr added a commit that referenced this issue Mar 21, 2022
m-mohr added a commit that referenced this issue Mar 21, 2022
@m-mohr m-mohr linked a pull request Mar 21, 2022 that will close this issue
m-mohr added a commit that referenced this issue Mar 23, 2022
@m-mohr m-mohr closed this as completed Mar 23, 2022
@m-mohr m-mohr modified the milestones: 1.3.0, 2.0.0 Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant