From bd9c9d457efdaeee59acd8e930c9c95caddcb3f0 Mon Sep 17 00:00:00 2001 From: Stefaan Lippens Date: Tue, 28 Jan 2025 18:24:03 +0100 Subject: [PATCH] Skip test for #714 on py3.8 due to lack of geopandas support Workaround for #714 requires at least geopandas 0.14 but that version is not available on Python 3.8 (#717) --- setup.py | 4 +++- tests/extra/job_management/test_job_management.py | 7 ++++++- 2 files changed, 9 insertions(+), 2 deletions(-) diff --git a/setup.py b/setup.py index eece58159..3d044bfb5 100644 --- a/setup.py +++ b/setup.py @@ -25,7 +25,9 @@ "urllib3<2.3.0", # httpretty doesn't work properly with urllib3>=2.3.0. See #700 and https://github.com/gabrielfalcao/HTTPretty/issues/484 "netCDF4>=1.7.0", "matplotlib", # TODO: eliminate matplotlib as test dependency - "geopandas>0.13.2", + # TODO #717 Simplify geopandas constraints when Python 3.8 support is dropped + "geopandas>=0.14; python_version>='3.9'", + "geopandas", # Best-effort geopandas dependency for Python 3.8 "flake8>=5.0.0", "time_machine", "pyproj>=3.2.0", # Pyproj is an optional, best-effort runtime dependency diff --git a/tests/extra/job_management/test_job_management.py b/tests/extra/job_management/test_job_management.py index 31804e537..46108f0fa 100644 --- a/tests/extra/job_management/test_job_management.py +++ b/tests/extra/job_management/test_job_management.py @@ -1,4 +1,5 @@ import copy +import datetime import json import logging import re @@ -7,7 +8,6 @@ from time import sleep from typing import Callable, Union from unittest import mock -import datetime import dirty_equals import geopandas @@ -40,6 +40,7 @@ ) from openeo.rest._testing import OPENEO_BACKEND, DummyBackend, build_capabilities from openeo.util import rfc3339 +from openeo.utils.version import ComparableVersion @pytest.fixture @@ -977,6 +978,10 @@ def test_initialize_from_df_on_exists_skip(self, tmp_path): ) assert set(db.read()["some_number"]) == {1, 2, 3} + @pytest.mark.skipif( + ComparableVersion(geopandas.__version__) < "0.14", + reason="This issue has no workaround with geopandas < 0.14 (highest available version on Python 3.8 is 0.13.2)", + ) def test_read_with_crs_column(self, tmp_path): """ Having a column named "crs" can cause obscure error messages when creating a GeoPandas dataframe