-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hv issue719 job manager threaded job start #736
base: master
Are you sure you want to change the base?
Conversation
@soxofaan maybe good to rediscuss from this point (local unit tests are passing) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some quick notes
by the way, I don't think you had to create a new PR, you just could have continued on #730 by pushing to its feature branch (we now have three open PRs for this feature I think, which gets a bit messy) |
worked on your initial comments @soxofaan currently checking why some unit tests are not passing |
indeed, that problem has been fixed on master by now |
One issue I still see now and want to resolve is that currently launching jobs (to queue them for start) is still tied in to the backend load. This means than when running at full capacity you will not already 'precreate jobs' which can instantly start running |
I'm not sure that pre-creating jobs instead of on the fly like we currently do will make that big of a difference as the time to create a job is usually negligible compared to the required time to start a job. Or do you experience different timings? |
@soxofaan adjusted the unit tests and resolved the small bugs. I also proposed to split off the _JobManagerWorkerThread to allow it in the future to also contain alternative threads for downloading, jobworkerthreadpools, ..... |
No description provided.