Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for common errors in spatial_extent #284

Open
EmileSonneveld opened this issue Apr 23, 2024 · 6 comments
Open

Check for common errors in spatial_extent #284

EmileSonneveld opened this issue Apr 23, 2024 · 6 comments

Comments

@EmileSonneveld
Copy link
Contributor

Users often type errors in spatial extent. This often gives errors, but sometimes very obscure ones.

For example:
'spatial_extent': {'west': [0], 'south': 60.11, 'east': 25.24, 'north': 60.35, 'crs': 'EPSG:4326'},
'spatial_extent': [1,2,3,4],

The following already gives an error:
"spatial_extent": {"east": 4, "north": 51.22, "south": 51.215, "west": 5}, -> geotrellis.vector.ExtentRangeError: Invalid Extent: xmin must be less than xmax (xmin=5.07, xmax=4.08)

Maybe we can also catch UTM coordinates while no CRS is specified.

@EmileSonneveld
Copy link
Contributor Author

User example that could be caught by this:

        "spatial_extent": {
          "west": 4329317.717132108,
          "east": 4330615.2810456185,
          "north": 3005295.0854642093,
          "south": 3003997.791438847
        },

j-240516d78c86445aa82203c98bcbab49

@JeroenVerstraelen JeroenVerstraelen transferred this issue from Open-EO/openeo-geotrellis-extensions May 21, 2024
@soxofaan
Copy link
Member

Also make sure this is included in the /validation code path

@EmileSonneveld
Copy link
Contributor Author

The missing CRS code with UTM coordinates was solved in this ticket: Open-EO/openeo-geopyspark-driver#815

When doing checks on the extent, this error is raised:
collection_id 'SENTINEL2_L2A': Unsupported spatial extent: {'west': 4329317.717132108, 'south': 3003997.791438847, 'east': 4330615.2810456185, 'north': 3005295.0854642093, 'crs': 'EPSG:4326'}

@EmileSonneveld
Copy link
Contributor Author

'spatial_extent': [1,2,3,4], now gives:
openeo.rest.OpenEoClientException: Invalid geometry argument: [1, 2, 3, 4]
Was fixed in: Open-EO/openeo-python-client#678

@EmileSonneveld EmileSonneveld removed their assignment Jan 20, 2025
@soxofaan
Copy link
Member

'spatial_extent': [1,2,3,4] now gives: openeo.rest.OpenEoClientException: Invalid geometry argument: [1, 2, 3, 4]. Was fixed in: Open-EO/openeo-python-client#678

Open-EO/openeo-python-client#678 only addresses the issue if the user uses load_collection from python client at that point. I think it still makes sense to do this kind of input checking at driver level regardless of used client

@EmileSonneveld
Copy link
Contributor Author

Then we can keep this ticket open for the moment.
I was just clearing out some old tickets

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants