Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NestJS v11 Support #862

Open
estiller opened this issue Jan 20, 2025 · 3 comments
Open

NestJS v11 Support #862

estiller opened this issue Jan 20, 2025 · 3 comments

Comments

@estiller
Copy link

Hi,
After upgrading our project to NestJS v11, we get an unmet peer dependency warning:

└─┬ @openapitools/openapi-generator-cli 2.15.3
  └─┬ @nestjs/core 10.4.6
    ├── ✕ unmet peer @nestjs/microservices@^10.0.0: found 11.0.3
    └── ✕ unmet peer @nestjs/platform-express@^10.0.0: found 11.0.3

I can open a PR that updates the pinned dependencies of openapi-generator-cli, but I see an earlier similar PR (#849) that wasn't approved for quite a while. Should I open a new PR? Do you want to update the PR mentioned above?

Thanks!

@wing328
Copy link
Member

wing328 commented Jan 22, 2025

I just asked the author of that PR to resolve the merge conflicts

is it correct to say that you've reviewed the change in #849 and confirmed the change fixed the issue you reported?

@estiller
Copy link
Author

estiller commented Jan 22, 2025

@wing328, unfortunately, that PR is 2 months old and doesn't reference NestJS v11 (which wasn't available then).
I opened a new PR that addresses this - #870. A maintainer needs to approve the GitHub Action Workflow before it's executed.

@estiller
Copy link
Author

For anyone interested, until the dependencies get updated, I implemented a workaround in our package.json that uses PNPM:

  "pnpm": {
    "overrides": {
      "@openapitools/openapi-generator-cli>@nestjs/axios": "^4.0.0",
      "@openapitools/openapi-generator-cli>@nestjs/common": "^11.0.6",
      "@openapitools/openapi-generator-cli>@nestjs/core": "^11.0.6",
      "@openapitools/openapi-generator-cli>@nestjs/platform-express": "^11.0.6",
      "@openapitools/openapi-generator-cli>reflect-metadata": "^0.2.2"
    }
  }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants