Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REQ] Laravel generator status #20437

Open
gijs-blanken opened this issue Jan 10, 2025 · 7 comments
Open

[REQ] Laravel generator status #20437

gijs-blanken opened this issue Jan 10, 2025 · 7 comments

Comments

@gijs-blanken
Copy link

Is your feature request related to a problem? Please describe.

I’ve been looking into the Laravel generator and noticed it could use some love. It's outdated and doesn’t fully align with the OpenAPI generator philosophy. It also doesn’t reflect some of the modern approaches seen in other generators, like the Symfony generator. This makes it harder to use the generated code without significant customization.

Describe the solution you'd like

First, I’d like to understand the current status of the Laravel generator:

  • Is it actively maintained?
  • If so, who is the current maintainer?

If there’s no active maintainer, I’d like to help improve it. My goal would be to rewrite parts of the Laravel generator to make it more user-friendly. For example, I really like how the Symfony generator produces a complete controller and leaves the API interface for the user to implement—it’s clean and efficient. I think the Laravel generator could benefit from a similar approach.

I’d also update it to support the latest PHP and Laravel versions (like PHP 8.3 and Laravel 11) and ensure it’s ready for modern development. Beyond that, I’d explore other improvements, but those are my initial ideas.

Additional context

I think improving the Laravel generator could save a lot of time for developers and make it much easier to integrate with modern projects. I’d love to hear more about its current status and whether anyone’s actively maintaining it. If not, I’d be happy to contribute and help bring it up to speed!

@wing328
Copy link
Member

wing328 commented Jan 11, 2025

Is it actively maintained?

looking at the merged PRs for Laravel: https://github.com/OpenAPITools/openapi-generator/pulls?
q=is%3Apr+is%3Amerged+Laravel+, I would say it's active.

I’d be happy to contribute and help bring it up to speed!

Yes please 🙏

Let me know if you need any help.

Look forward to your contributions.

@gijs-blanken
Copy link
Author

I'm interested in either adapting the Laravel generator to follow a server interface paradigm like the Sympfony generator, or to create a new generator that follows this. Do you have a preference for either option? I can't imagine people really using the Laravel generator in it's current state but you might want to have both the stub and interface options available.

On another note, is there any trick to improve build times for the project? I'm averaging 3 minute build times and it's a little annoying 😅

Thanks in advance @wing328 !

@wing328
Copy link
Member

wing328 commented Jan 14, 2025

On another note, is there any trick to improve build times for the project? I'm averaging 3 minute build times and it's a little annoying 😅

What about using -DskipTests=true? e.g. mvn clean package -DskipTests=true

@wing328
Copy link
Member

wing328 commented Jan 14, 2025

I'm interested in either adapting the Laravel generator to follow a server interface paradigm like the Sympfony generator, or to create a new generator that follows this.

I prefer the former - adapting the Laravel generator to follow a server interface paradigm like the Symphony generator

@gijs-blanken
Copy link
Author

On another note, is there any trick to improve build times for the project? I'm averaging 3 minute build times and it's a little annoying 😅

What about using -DskipTests=true? e.g. mvn clean package -DskipTests=true

This is the command I'm running: ./mvnw clean install -DskipTests -Dmaven.javadoc.skip=true

@gijs-blanken
Copy link
Author

I'm interested in either adapting the Laravel generator to follow a server interface paradigm like the Sympfony generator, or to create a new generator that follows this.

I prefer the former - adapting the Laravel generator to follow a server interface paradigm like the Sympfony generator

I'm on it!

@wing328
Copy link
Member

wing328 commented Jan 14, 2025

On another note, is there any trick to improve build times for the project? I'm averaging 3 minute build times and it's a little annoying 😅

What about using -DskipTests=true? e.g. mvn clean package -DskipTests=true

This is the command I'm running: ./mvnw clean install -DskipTests -Dmaven.javadoc.skip=true

Please give it a try with package instead of install.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants