Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When I create a technical inject in a simulation and I remove the expectation, expectations still there #2316

Open
RomuDeuxfois opened this issue Jan 29, 2025 · 5 comments
Assignees
Labels
bug use for describing something not working as expected
Milestone

Comments

@RomuDeuxfois
Copy link
Member

Description

  1. Go to a simulation
  2. Go to inject creation
  3. Select a technical one and remove expectations
  4. Create it
  5. Go to the created inject
  6. Expectations are present
@RomuDeuxfois RomuDeuxfois added bug use for describing something not working as expected needs triage use to identify issue needing triage from Filigran Product team labels Jan 29, 2025
@EllynBsc
Copy link
Member

Yes indeed not working, after reproducing the steps, I get this update drawer:

Image

Expected output: expectations not present as we removed them on the creation of an inject
Actual output: expectations present

@EllynBsc EllynBsc removed the needs triage use to identify issue needing triage from Filigran Product team label Jan 29, 2025
@EllynBsc EllynBsc added this to the Bugs backlog milestone Jan 29, 2025
@RomuDeuxfois RomuDeuxfois self-assigned this Feb 3, 2025
@RomuDeuxfois
Copy link
Member Author

@EllynBsc This was done on purpose at the code level.
Do we confirm that the UI should tell what we must save? If there are no expectations, then we don't create them by default? Today, we create technical expectations by default if if it's empty.

@jborozco
Copy link

jborozco commented Feb 5, 2025

@RomuDeuxfois

By default we always provide detection and prevention to technical injects
If the user wants to remove it via the UI he should be able to have the option.

Is this logic blocking us in some way ?

@RomuDeuxfois
Copy link
Member Author

@RomuDeuxfois

By default we always provide detection and prevention to technical injects If the user wants to remove it via the UI he should be able to have the option.

Is this logic blocking us in some way ?

Not all

Actual logic:

  • User create a technical inject with expectations -> we create expectations provided by the user
  • User create a technical inject without expectations -> we create prevention & detection expectations by default
  • User update a technical inject by removing expectations -> OK

New logic:

  • User create a technical inject with expectations -> we create expectations provided by the user
  • User create a technical inject without expectations -> we don't create expectations by default
  • User update a technical inject by removing expectations -> OK

Ok for you ?

@EllynBsc
Copy link
Member

EllynBsc commented Feb 6, 2025

Yes I agree with the new logic of not having expectations by default if the user creates technical inject without expectations ( cc @jborozco )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug use for describing something not working as expected
Projects
None yet
Development

No branches or pull requests

3 participants