Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dependency management #5

Open
placer14 opened this issue Jan 17, 2020 · 0 comments
Open

Add dependency management #5

placer14 opened this issue Jan 17, 2020 · 0 comments
Labels
enhancement New feature or request

Comments

@placer14
Copy link
Member

placer14 commented Jan 17, 2020

There is no way to deterministically build this project using the correct dependency versions. I recommend adopting dep and ensuring the following dependencies are constrained:

  • github.com/OpenBazaar/wallet-interface constrained to ethereum-master
  • github.com/OpenBazaar/multiwallet constrained to ethereum-master
  • github.com/OpenBazaar/openbazaar-go constrained to ethereum-master
  • github.com/OpenBazaar/spvwallet constrained to ethereum-master

If dep is used, the following prune options must also be used so non-go files do not get removed from ensured dependencies:

[[prune.project]]
  name = "github.com/ethereum/go-ethereum"
  unused-packages = false

[[prune.project]]
  name = "github.com/karalabe/usb"
  unused-packages = false

In order to know this is working, we should be able to include this package in a fresh go environment and run one (or a few) commands to give the project the dependencies (in their appropriate version) it needs.

@placer14 placer14 added the enhancement New feature or request label Jan 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant