Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Newly added areas not listed right away #1243

Open
vnugent opened this issue Dec 19, 2024 · 2 comments
Open

Newly added areas not listed right away #1243

vnugent opened this issue Dec 19, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@vnugent
Copy link
Contributor

vnugent commented Dec 19, 2024

Steps to Reproduce

  1. Add a new a area. Example (Parent -> New area)
  2. Visit the parent area. The newly added area isn't listed

I believe 2 changes contribute to the caching issue:
a. we recently made an adjustment to Cloudflare cache (turn on Proxy for openbeta.io)
b. longer area page cache https://github.com/OpenBeta/open-tacos/pull/1234/files#diff-95ae8c28eafa1b51054aba9cd1574da984871e3fb0c47e615a4ea5da78231e35

@vnugent vnugent added the bug Something isn't working label Dec 19, 2024
@vnugent vnugent changed the title Newly added area not listed right away Newly added areas not listed right away Dec 19, 2024
@enapupe
Copy link
Contributor

enapupe commented Jan 14, 2025

I think it's option b, I've checked headers and

cf-cache-status: DYNAMIC
x-vercel-cache: HIT

perhaps there should be some cache invalidation logic when publishing a new area?
I believe this is the relevant docs https://nextjs.org/docs/app/api-reference/functions/revalidatePath

@vnugent
Copy link
Contributor Author

vnugent commented Jan 15, 2025

I think it's option b, I've checked headers and

cf-cache-status: DYNAMIC
x-vercel-cache: HIT

perhaps there should be some cache invalidation logic when publishing a new area? I believe this is the relevant docs https://nextjs.org/docs/app/api-reference/functions/revalidatePath

We're calling a custom function to revalidatePath after every update. Maybe it doesn't get called in this case?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants