Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tick should return Grade object #425

Open
Vichy97 opened this issue Nov 22, 2024 · 2 comments
Open

Tick should return Grade object #425

Vichy97 opened this issue Nov 22, 2024 · 2 comments
Labels

Comments

@Vichy97
Copy link
Collaborator

Vichy97 commented Nov 22, 2024

Ticks should use a Grade object instead of a string for grade. This should have all fields populated by the server when requesting a tick object.

@Vichy97 Vichy97 added Component: Log Book enhancement New feature or request labels Nov 22, 2024
@vnugent
Copy link
Contributor

vnugent commented Nov 30, 2024

Indirectly addressed by PR #433

@vnugent vnugent closed this as completed Nov 30, 2024
@Vichy97
Copy link
Collaborator Author

Vichy97 commented Dec 4, 2024

@vnugent I don't think that PR quite addresses this. It's true, that the climb has a Grade object, but I was planning on allowing the user to specify their proposed grade when ticking (similar to what you can do on MP). I don't think the climb object should be replacement for the existing grade field

@Vichy97 Vichy97 reopened this Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants