Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Polish scale (Kurtyka scale) #172

Open
Agilulfo opened this issue Sep 9, 2024 · 4 comments
Open

Add support for Polish scale (Kurtyka scale) #172

Agilulfo opened this issue Sep 9, 2024 · 4 comments

Comments

@Agilulfo
Copy link
Contributor

Agilulfo commented Sep 9, 2024

This scale is used in Poland for sport and trad climbs
see: https://en.wikipedia.org/wiki/Grade_(climbing)#Polish

@musoke
Copy link
Collaborator

musoke commented Sep 13, 2024

Would you like to work on this?

@Agilulfo
Copy link
Contributor Author

I don't speak typescript but having given a look at the changes to add the Brasilian scale I think I can pull it off with a little help in the code review.

@Agilulfo Agilulfo mentioned this issue Sep 17, 2024
7 tasks
@Agilulfo
Copy link
Contributor Author

Agilulfo commented Sep 17, 2024

@musoke I've pushed #173.

Am I on the right path? (see missing steps in PR description TODO list)

out of curiosity.. why is the data on grades duplicated? (there are both json and csv files.)

@musoke
Copy link
Collaborator

musoke commented Sep 18, 2024

out of curiosity.. why is the data on grades duplicated? (there are both json and csv files.)

Looks like you worked it out, but since you asked: the CSV is for human editing and the JSON is automatically generated from it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants