You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently, I don't use any file uploading logic in the platform and installing libmagic1 is a burden.
Currently there 7 use cases for magic and 6 of them uses filename to figure out the mime type. I think these cases be handled by following functionality from standard library:
Problem to Solve
Currently, I don't use any file uploading logic in the platform and installing
libmagic1
is a burden.Currently there 7 use cases for
magic
and 6 of them uses filename to figure out the mime type. I think these cases be handled by following functionality from standard library:https://docs.python.org/3/library/mimetypes.html#mimetypes.guess_type
The remaining case that uses the actual file buffer is not even a part of core library and found in examples:
client-python/examples/upload_artifacts.py
Line 54 in c978757
Current Workaround
You need to install
libmagic1
and relevant Python dependency. I could not find a way to get around this.Proposed Solution
Remove
magic
dependency by usingguess_type
instead from stdlib.If we really need
magic
for any reason, I propose making the dependency optional so those who don't do any file operations don't have to install it.The text was updated successfully, but these errors were encountered: