-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace URI/URL validators by simplesamlphp/assert #1775
Comments
We expect the simplesaml bundle to be better thought out. |
It seems that it can only be used when EB is supporting at least PHP7.4 or 8. The current assert library does not support the requested validators. |
Consider using https://github.com/guzzle/psr7 instead. It's already available in EB's dependency tree. |
@baszoetekouw I would personally opt to do this after the EB upgrade. What are your thoughts? |
Yes, makes sense. I'll remove it from the sprint. |
Replace our own implementation of uri/url validators in https://github.com/OpenConext/OpenConext-engineblock/tree/main/library/EngineBlock/Validator, and instead use the library from https://github.com/simplesamlphp/assert/tree/master
The text was updated successfully, but these errors were encountered: