Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace URI/URL validators by simplesamlphp/assert #1775

Open
baszoetekouw opened this issue Dec 6, 2024 · 5 comments
Open

Replace URI/URL validators by simplesamlphp/assert #1775

baszoetekouw opened this issue Dec 6, 2024 · 5 comments

Comments

@baszoetekouw
Copy link
Member

Replace our own implementation of uri/url validators in https://github.com/OpenConext/OpenConext-engineblock/tree/main/library/EngineBlock/Validator, and instead use the library from https://github.com/simplesamlphp/assert/tree/master

@johanib
Copy link
Contributor

johanib commented Dec 11, 2024

We expect the simplesaml bundle to be better thought out.
This output is used on the debug page

@pablothedude pablothedude self-assigned this Jan 7, 2025
@pablothedude
Copy link
Contributor

It seems that it can only be used when EB is supporting at least PHP7.4 or 8. The current assert library does not support the requested validators.

@tvdijen
Copy link
Contributor

tvdijen commented Jan 7, 2025

Consider using https://github.com/guzzle/psr7 instead. It's already available in EB's dependency tree.

@phavekes phavekes moved this from New to In Progress in PHP development Jan 8, 2025
@pablothedude
Copy link
Contributor

@baszoetekouw I would personally opt to do this after the EB upgrade. What are your thoughts?

@baszoetekouw
Copy link
Member Author

baszoetekouw commented Jan 8, 2025

Yes, makes sense. I'll remove it from the sprint.

@pablothedude pablothedude moved this from In Progress to icebox in PHP development Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: icebox
Development

No branches or pull requests

4 participants