Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove coin:policy_enforcement_decision_required checkbox #477

Open
baszoetekouw opened this issue Jan 16, 2025 · 0 comments
Open

Remove coin:policy_enforcement_decision_required checkbox #477

baszoetekouw opened this issue Jan 16, 2025 · 0 comments

Comments

@baszoetekouw
Copy link
Member

As PDP policies are now administered in Manage, it doesn't really make sense to check or uncheck the coin:policy_enforcement_decision_required metadata field manually. Rather, it should be automatically set by Manage if PDP policies are present for this entity (and unset if PDP policies are removed).

There are two possibilities:

  • remove the checkbox from the gui altogether and automatically send coin:policy_enforcement_decision_required in the push of PDP policies are present
  • make the checkbox in the gui readonly and let Manage set or unset the value of the checkbox when PDP polcies are added or removed.

I'm not sure which of the two is the best solution.
The first one is probably easier to implement and sounds a bit cleaner, but the second one is more transparent and allows the user to check what is happening.

In both cases though we are adding more business logic to Manage; I think that's unavoidable if we want to automate more of the support, but we should be careful how we implement these things. Maybe we can make such automations more generic and make them configurable in some way, so that the feature is more generally useful and rules like this don't get scattered around the code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: New
Development

No branches or pull requests

1 participant