Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syntax check on PDP fields #478

Open
baszoetekouw opened this issue Jan 17, 2025 · 0 comments
Open

Syntax check on PDP fields #478

baszoetekouw opened this issue Jan 17, 2025 · 0 comments

Comments

@baszoetekouw
Copy link
Member

It would be nice if attribtue values of PDP checks would be syntax checked.

I.e.:

  • SURFteams grouop name: make sure it start with urn:collab:group:surfteams.nl:nl:surfnet:diensten
  • SAB role: make sure it is a single word like "Infrabeheerder" and maybe even check it against a list of known values
  • affiliation: check against the list of known values
  • entitlement: check this it is an uri (url or urn)
  • scoped-affiliation: make sure it is of form <affiliation>@<domain>
  • mail address: make sure it looks like an email address
  • schac: make sure it looks like a domain. For bonus points, check that the schachome is defined in a shic-scope for an existing IdP in Manage.

In all cases, show any mismatched in the UI, but allow a user to submit/override "incorrect" values, if they wish. It is very probably that in some cases, we need to send out-of-spec values (for example, undefined affiliations).

Similar to #447, we need to find. a generic way to do this, so these kinds of business rules are not hardcoded in the application.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: New
Development

No branches or pull requests

1 participant