Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to CMake and add options #4

Open
yegorich opened this issue Aug 4, 2020 · 3 comments
Open

Move to CMake and add options #4

yegorich opened this issue Aug 4, 2020 · 3 comments

Comments

@yegorich
Copy link

yegorich commented Aug 4, 2020

What about moving the build system to CMake and introduce compile-time options like, for example, ENABLE_BACKUP?

@pcercuei
Copy link
Member

pcercuei commented Aug 5, 2020

I like CMake so it would be a good option, but why would you need a switch for ENABLE_BACKUP? If you don't need it it's not in the way, so I think it's fine if it's built-in.

@yegorich
Copy link
Author

yegorich commented Aug 5, 2020

The REAMDE.md states the following:

If you want to customize or remove the update mechanism, edit the perform_updates() function in mininit.c.

So if you don't need the backup mechanism that is on by default, you can disable it via specifying a CMake option like this:

cmake -DENABLE_BACKUP=OFF

This way, you don't need to modify the source code. The use case for this were, if you have constrained space and you cannot afford to maintain three images at once: rootfs, rootfs.bkp and update image.

@pcercuei
Copy link
Member

pcercuei commented Aug 6, 2020

What I mean, is that if you have the need for upgradable rootfs, just don't use it. It's not that much more code anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants