Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Epic: Runtime Engine #393

Closed
6 of 7 tasks
NickOpenFn opened this issue Sep 22, 2023 · 7 comments
Closed
6 of 7 tasks

Epic: Runtime Engine #393

NickOpenFn opened this issue Sep 22, 2023 · 7 comments
Assignees
Labels

Comments

@NickOpenFn
Copy link

NickOpenFn commented Sep 22, 2023

Epic to track the work needed in the multi-process runtime worker.

Remember we don't have a good name for this (runtime manager is insufficient). See #374. Runtime Worker might be useful.

Essential

Useful

Optional

To close

  • New runtime manager service #52 is irrelevant now, I just need to look into that mysterious comment and either transfer notes to a new issue or close it down

Not in issues

Stuff that needs doing that we don't have issues for

  • Support the sanitize log flag
  • Does the existing service worker even support workflows? Does it need to do anything for that?
  • Lazy loading assets (state/credentials)~~ (basically done but I'm testing)
  • At the moment we use worker threads to run the jobs (with compilation in the main thread). I don't know if this is its final form. But we should be able to swap this out later.
  • Caching compiled jobs
  • Update API to meet new standards
  • Log version numbers (there is a wider story about logging but right now we'll just do the minimum)

Security?

Security considerations for the actual process worker are more to do with not allowing malicious code to run and not allowing other environments/processes/jobs to be read. A lot of the security is subsumed by the enclosing server.

@NickOpenFn NickOpenFn changed the title Epic: Runtime Manager Backend Epic: Runtime Manager Sep 22, 2023
@NickOpenFn NickOpenFn changed the title Epic: Runtime Manager Epic: Runtime Manager Backend Sep 22, 2023
@NickOpenFn NickOpenFn pinned this issue Sep 22, 2023
@NickOpenFn NickOpenFn transferred this issue from OpenFn/docs Sep 22, 2023
@josephjclark josephjclark changed the title Epic: Runtime Manager Backend Epic: Runtime Engine Oct 6, 2023
@josephjclark

This comment was marked as resolved.

@josephjclark josephjclark self-assigned this Oct 11, 2023
@josephjclark

This comment was marked as resolved.

@josephjclark
Copy link
Collaborator

TODO validate incoming workflows/attempts to make sure they're what we expect.

This is good practice generally but more interestingly it'll keep the worker honest. On that note, the worker should do some validation too on the incoming attempts

@josephjclark

This comment was marked as resolved.

@josephjclark

This comment was marked as resolved.

@josephjclark

This comment was marked as resolved.

@josephjclark josephjclark mentioned this issue Oct 18, 2023
17 tasks
@josephjclark
Copy link
Collaborator

Closing this down as it's no longer useful - the work has been done or branched off

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants