see what happens if we remove the flaky mark #1152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s cancled each time a push is made
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1152 +/- ##
==========================================
- Coverage 93.53% 91.89% -1.64%
==========================================
Files 142 142
Lines 10635 10632 -3
==========================================
- Hits 9947 9770 -177
- Misses 688 862 +174
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
No API break detected ✅ |
IAlibay
reviewed
Feb 23, 2025
| @@ -931,7 +931,7 @@ def test_openeye_import_error(self, monkeypatch, uncharged_mol): | |||
| @pytest.mark.slow | |||
| @pytest.mark.download | |||
| # Sometimes we get a DOI lookup error from duecredit | |||
| @pytest.mark.flaky(reruns=3, only_rerun=ValueError, reruns_delay=10) | |||
| #@pytest.mark.flaky(reruns=3, only_rerun=ValueError, reruns_delay=10) | |||
There was a problem hiding this comment.
It would be good to not leave this lying around long term. @mikemhenry or @atravitz could you open an issue to track the removal (or re-addition) of this flaky mark?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
newsentryDevelopers certificate of origin