tests.py - write some tests

[Treblesteph]

I want to add tests for all functions in tasks.py, and maybe for those in views.py too... but then I remembered that when I was trying to get the demo up and running, I ran into a problem with the file handle. I didn't completely understand the whole issue, but it seemed to be quite hard to debug, so might be worth writing a test to help if a similar thing were to happen to someone else.

@madprime, what do you think?

[Treblesteph]

pasted from slack discussion on this issue:

this wasn't simple to debug. s3 was throwing an error, possibly due to not getting content from your filehandle. I think it wasn't getting content from the filehandle because you had read the whole thing and printed it to console with handle_uploaded_file. if you comment out calling that, it works.

to be clear, the bug today was pretty hard, I'm glad I took some time to look at it for you. In case it helps, here's what I did...

I discovered S3 was erroring and did print(req2.content) to try to get an error message. Then I pasted that into google. I found a lot of complaints about S3 rejections due to missing content-length headers. (In the HTTP "headers" accompany requests and responses – in this case for the PUT.)

Then I went on the wrong track for a while wondering if the header was missing in the PUT that requests was making due to some version difference, tried running this code in python3 (which raises all sorts of issues) updating random libraries (issues pile up). That was all the wrong track.

Then I think I went back to reading internet comments, and I maybe saw one complaining that requests doesn't send content-length for empty content? It might not have said exactly that. Somehow I realized, "oh no, maybe the content is empty because it's been read and printed already" and that was the problem.

[madprime]

Tests sound good to me! It might help think through code structure too, into testable units 👍

…

On Mon, Feb 19, 2018 at 8:03 AM Stephanie Smith-Unna < ***@***.***> wrote: pasted from slack discussion on this issue: this wasn't simple to debug. s3 was throwing an error, possibly due to not getting content from your filehandle. I think it wasn't getting content from the filehandle because you had read the whole thing and printed it to console with handle_uploaded_file. if you comment out calling that, it works. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <https://github.com/Treblesteph/oh-data-demo-template/issues/5#issuecomment-366735706>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAFCx1ZvMJsaSxblpOIhIxVeWUNb0i2qks5tWZtLgaJpZM4SKxkB> .