Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

If a.git directory exists in the plugin directory it will test every .git sub-directory as a possible plugin. #126

Open
seamustuohy opened this issue Feb 12, 2016 · 2 comments
Open

If a.git directory exists in the plugin directory it will test every .git sub-directory as a possible plugin. #126

seamustuohy opened this issue Feb 12, 2016 · 2 comments
Labels
bug

Comments

@seamustuohy
Copy link
Contributor

The get_plugins function will iterate through the various levels of the .git directory unnecessarily.. This will need to be addressed before we can implement issue #124
@seamustuohy
Copy link
Contributor Author

It turns out that this was not the issue. It should still be addressed because it iterates over every sub-directory of the .git folder, but it does not cause a crash or any other side-effects I can identify.

@seamustuohy seamustuohy changed the title If a .git directory exists in the plugin directory flask will crash If a.git directory exists in the plugin directory it will test every .git sub-directory as a possible plugin. Feb 17, 2016
@seamustuohy seamustuohy mentioned this issue Feb 17, 2016
Closed
5 tasks
@seamustuohy
Copy link
Contributor Author

To fix this I suggest having the path walk ignore any directories named .git. This should limit the extraneous debug messages and extra work being done by the application because of the .git directory.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@seamustuohy