New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Label fields within integers should be valid without having to be explicitly listed in a range #1995

Open

peternewman opened this issue Feb 24, 2025 · 1 comment

Labels

Component-RDM Difficulty-Easy enhancement Language-C++

Member

peternewman commented Feb 24, 2025

Or alternatively for now add a test that flags when a label isn't in the valid list...

I.e. IsValid should check LabeledValues as well as Intervals before complaining the value isn't valid.

Although the error status (via the name) would need to include all the labels too!

This also wouldn't be backwards compatible for older OLA versions, as the value wouldn't be present in the range.

peternewman added Component-RDM Difficulty-Easy enhancement Language-C++ labels

Member Author

peternewman commented Feb 24, 2025 •

edited

Loading

This is currently only an issue when there are ranges specified...

But otherwise it assumes that anything is valid...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment