Modern image format support

[m-overlund]

I think OpenMage should include support for modern image formats, like webP, out of the box.

Yireo has done some great work in this regard:
https://github.com/yireo-magento1/Yireo_Webp

Also in regards to improving the page speed of OpenMage.

[addison74]

I agree to add webp file format for images. The only issue is related to extension itself. It needs to be intensive tested before being merged into OpenMage and we cannot count on developer's help. There are a few open issues but I did not check them in detail.

[m-overlund]

I agree. When i tested on our setup, some images failed conversion, resulting in zero byte webP files = broken images.
So maybe some checks for CMYK or other things fails or is needed.

[justinbeaty]

Another solution that requires no changes to OpenMage is to have some script that automatically makes webp versions of images in the media directory at some interval using cron or other methods.

Then, depending on the webserver (nginx or apache) you can serve the appropriate image to the web browser based on headers. This is how I do it with my OpenMage store.

nginx example:

map $http_accept $webp_suffix {
    default   "";
    "~*webp"  ".webp";
}
server {
    # ...
    location ~* \.(png|jpg)$ {
        # Only GET is allowed here
        limit_except GET { deny all; }

        try_files $uri$webp_suffix $uri =404;
    }
}

Apache example: https://gist.github.com/seeekr/2415528

Note that the two work slightly differently, the nginx config expects "imagename.jpg.webp" where the apache example expects "imagename.webp". I prefer the former just in case two files had the same name, like "imagename.jpg" and "imagename.png"

[addison74]

Interesting approach. Many thanks for sharing.

[Flyingmana]

just a personal opinion, we dont need to include everything into the main project, some things are fine to have as optional modules.
I see this as one of this cases, as basically the current formats we support are working, and are not fully terrible, but there are numerous approaches to improve it. Also there are several image formats, and this now only talks about one.

That said, Iam not against it and there definitive should be a way/an option to support newer formats. I just think, a separate module is generally ok.

[justinbeaty]

I agree that a separate module is fine. I have only quickly looked at the module, and it includes jQuery, and also seems to run blocking JS that modifies the DOM, which is bad for pagespeed. Plus it looks like it prefers to call a binary on the server to do the conversion.

[luigifab]

Are you watching me? I started the update of own of my module to automagically generate webp images same day of your question.

[m-overlund]

yes... yes I am (:

[m-overlund]

Sounds great - would love to test it out!

[luigifab]

The final crash test is ending!

To test it at localhost, tomorrow, you will need to run (I still not updated my documentation, 3 minutes light late):

• composer require luigifab/openmage-apijs (6.9.0+)
• composer require luigifab/openmage-maillog (5.4.0+).
• git apply changes.diff

You also need to install: python3-pil and python3-scour (Pillow for jpg jpeg gif png webp images, Scour for svg images).

1/ Then, go to System / Configuration / Dialogs boxes, and set Yes everywhere in General.

2/ Then, go to System / Configuration / Emails and wysiwyg directives, and create a Picture directive, for example:

3/ Then, go to your home cms page, add the following test: {{picture code="test" product="simple" attribute="image"}} (update the sku "simple" with an existing product sku with images). Go to your frontend:

Yes this is not automatic, you will need to update all your templates.

[luigifab]

Like us, you will love the animated GIF/PNG/WEBP resizing!

[fballiano]

I suggest to use a CDN which can automatically generate web images and recompress all of the images to match google' standards. I use one for all my customers, a few bucks/months and we avoid having hunderds thousands converted images on our servers.

[m-overlund]

Anyone you'd recommend for OpenMage?

[fballiano]

I use BunnyCDN for all my customers

[yafully]

My website uses My website adopts requireJs and jquery no prototypeJs, webp, less, ngx pagespeed, etc, but it is based on OPENMAGE and runs very smooth on PHP7.2 MYSQL5.7. Thank you for your hard work.

Site Address

[kiatng]

PR #3384 and #3403 merged!