Add php 7.4 Opcache Preloading capability

[Flyingmana]

Related Links

• https://wiki.php.net/rfc/preload
• https://dev.to/restoreddev/introduction-to-php-7-4-preload-4lg4
• https://github.com/restoreddev/preloading-example
• [DI] generate preload.php file for PHP 7.4 in cache folder symfony/symfony#32032
• [HttpKernel][DI] allow bundles to declare classes that should be preloaded symfony/symfony#33689

Tasks

• add basic capability to preload a class
• preload a set of much used Classes
• introduce a config to allow modules defining own lists of classes for preloading
• make sure it does not break with older PHP versions

[seansan]

How would we apply this? https://github.com/restoreddev/preloading-example/blob/master/preload.php

Would we preload ALL files? Or start with /lib first? or /app/code?

It seems to me that we could already test this quite easily if someone is running 7.4? Just set the path to the preload.php file and make the file compatible with Magento structure

The questions would then remain

• how do we protect /preload.php or is it placed 1 folder under public_html? (you dont want outsiders to access it)

• would we offer some static variable in preload.php to control which folders we do or dont preload? (see above LIB only, all code or also templates?)

• which folders would we preload, with which include statement *.php + *.phtml? and which ignore?

• also after changing files we would have to restart php, but is there maybe also a refresh pleload routine?

In short:

• can we already create some preload.php file for M1?
• and where would we safely place it?

[colinmollenhour]

The output of Aoe_ClassPathCache would be a good way to create a preload file for testing before doing a full implementation. Compared against a well-tuned opcache (plenty of memory to never have evictions) and running Aoe_ClassPathCache I'm not expecting a huge improvement, though. Hopefully I'm proven wrong. :)

[Flyingmana]

We probably dont want to add all files, but often used ones. Probably rather have it configurable as some people prefer memory efficiency, and others full speed, and people need to do benchmarks.

@colinmollenhour the preloading is for avoiding the uncached initial requests, which in some high usage scenarious especially with docker can be a big difference. (I know of one Company, who did still use the M1 Magento Compiler, as it made big differences for some of their customers performance wise as beeing able to cause outages during high traffic scenarious.)

[seansan]

From reading the article there is another improvement and that is that the cache does not have to be validated every request And for every file and that bit/mem usage improvements can be applied in php internally because the codes is presumed to be static. Also a cache lookup is not necessary (is it there) because php assumes it to be there. Freely interpretated

…

On Fri, 11 Sep 2020 at 20:15, Daniel Fahlke ***@***.***> wrote: We probably dont want to add all files, but often used ones. Probably rather have it configurable as some people prefer memory efficiency, and others full speed, and people need to do benchmarks. @colinmollenhour <https://github.com/colinmollenhour> the preloading is for avoiding the uncached initial requests, which in some high usage scenarious especially with docker can be a big difference. (I know of one Company, who did still use the M1 Magento Compiler, as it made big differences for some of their customers performance wise as beeing able to cause outages during high traffic scenarious.) — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#816 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAE7I22226PD4PX4XZWL4SDSFJSLFANCNFSM4I25DPBA> .