Replace all usages of prototype.gsub with .replace

[Flyingmana]

https://www.tutorialspoint.com/prototype/prototype_string_gsub.htm

https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/replace

example: https://github.com/OpenMage/magento-lts/pull/2051/files

[fballiano]

if i'm not mistaken we should use replaceAll instead of replace

[fballiano]

Actually maybe there's almost nothing to do here because:

fab@MBP-Fab ~/P/magento-lts (issue_2054_replace_gsub)> grep -r 'gsub' *
js/mage/adminhtml/wysiwyg/widget.js:        return this.widgetOptionsEl.id + '_' + this.widgetEl.value.gsub(/\//, '_');
js/mage/adminhtml/wysiwyg/widget.js:                widgetCode.gsub(/([a-z0-9\_]+)\s*\=\s*[\"]{1}([^\"]+)[\"]{1}/i, function(match){
js/mage/adminhtml/wysiwyg/tiny_mce/setup.js:        return content.gsub(/<([a-z0-9\-\_]+.+?)([a-z0-9\-\_]+=".*?\{\{.+?\}\}.*?".+?)>/i, function(match) {
js/mage/adminhtml/wysiwyg/tiny_mce/setup.js:            attributesString = attributesString.gsub(/([a-z0-9\-\_]+)="(.*?)(\{\{.+?\}\})(.*?)"/i, function(m) {
js/mage/adminhtml/wysiwyg/tiny_mce/setup.js:        return content.gsub(/\{\{widget(.*?)\}\}/i, function(match){
js/mage/adminhtml/wysiwyg/tiny_mce/setup.js:        return content.gsub(reg, function(match) {
js/mage/adminhtml/wysiwyg/tiny_mce/setup.js:        return content.gsub(/<img([^>]+id=\"[^>]+)>/i, function(match) {
js/mage/adminhtml/wysiwyg/tiny_mce/setup.js:        attributes.gsub(/(\w+)(?:\s*=\s*(?:(?:"((?:\\.|[^"])*)")|(?:'((?:\\.|[^'])*)')|([^>\s]+)))?/, function(match){
js/prototype/prototype.js:  function gsub(pattern, replacement) {
js/prototype/prototype.js:    return this.gsub(pattern, function(match) {
js/prototype/prototype.js:    this.gsub(pattern, iterator);
js/prototype/prototype.js:          value = value.gsub('+', ' ');
js/prototype/prototype.js:    gsub:           gsub,
js/prototype/prototype.js:    return this.template.gsub(this.pattern, function(match) {
js/prototype/prototype.js:    value = value.gsub(/(\r)?\n/, '\r\n');
js/prototype/prototype.js:    value = value.gsub(/%20/, '+');
js/scriptaculous/unittest.js:      test = test.gsub(/(\.should[^\(]+\()/,'#{0}this,');
js/scriptaculous/unittest.js:      test = test.gsub(/(\.should[^\(]+)\(this,\)/,'#{1}(this)');
js/scriptaculous/unittest.js:        var testName = 'test'+specName.gsub(/\s+/,'-').camelize();
js/scriptaculous/builder.js:          '="' + attributes[attribute].toString().escapeHTML().gsub(/"/,'&quot;') + '"');
lib/phpseclib/File/X509.php:        $oldsigsubj = $this->signatureSubject;
lib/phpseclib/File/X509.php:            $this->signatureSubject = $oldsigsubj;
lib/phpseclib/File/X509.php:        $this->signatureSubject = $oldsigsubj;

The only files we've to change are the ones in js/mage/adminhtml/wysiwyg right?

[tmotyl]

Why are issues like this converted to discussion? Its a valid issue

[addison74]

If it is a valid issue we can "Create issue from discussions".

As a personal observation, the Discussions section was created recently. If it had been created some time ago we would not have faced in the Issues section a mixture of situations and here I am referring to ideas, questions, issues, requests for help.

It can be seen that through a joint effort both Issues and PR sections were almost halved in just one month and posts are analyzed daily. It is unfortunate that many threads have been left behind for years and no conclusion has been reached because in the meantime many authors and contributors are no longer active on GitHub.