Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LoongArch64: AXPBY Interface Correctness Assurance #4455

Closed
XiWeiGu opened this issue Jan 24, 2024 · 4 comments · Fixed by #4470
Closed

LoongArch64: AXPBY Interface Correctness Assurance #4455

XiWeiGu opened this issue Jan 24, 2024 · 4 comments · Fixed by #4470

Comments

@XiWeiGu
Copy link
Contributor

XiWeiGu commented Jan 24, 2024

AXPBY is introduced as BLAS extensions, but I haven't found corresponding correctness tests. LoongArch64 has added corresponding optimizations, but correctness cannot be guaranteed. What should be done in this case?

@XiWeiGu XiWeiGu changed the title AXPBY Interface Correctness Assurance LoongArch64: AXPBY Interface Correctness Assurance Jan 24, 2024
@martin-frbg
Copy link
Collaborator

Hmm, awkward. Seems this was added ten years ago (#285) without test cases - and as it is an extension, it is not covered by the small testsuites in test and ctest (which were taken from the Reference BLAS) and neither by the standalone BLAS-Tester (based on the ATLAS testsuite). No other implementation uses it internally (except GEADD which is an extension without testcases itself). Guess one would need to create at least something simple in utest (comparing to known good results from a C implementation like the one in kernel/arm, or from certain "competing" packages)

@martin-frbg
Copy link
Collaborator

Oops, your wish was just fulfilled by @kseniyazaytseva in #4457 - sometimes things are moving a bit too fast here for me

@XiWeiGu
Copy link
Contributor Author

XiWeiGu commented Jan 25, 2024

Thank you for your prompt reply. I have an additional question: Is it forgotten or is there some other reason that {s/d/sc/dz}amax doesn't have CBLAS interfaces.

@martin-frbg
Copy link
Collaborator

Can't say if it was forgotten, or if it was intentionally excluded as it is a BLAS extension. This appears to be a historical choice (or oversight) dating back to GotoBLAS, and it seems only the (comparatively recent) cmake build creates these cblas functions "by accident" while the Makefile does not have them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants