-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature request] Allow linking a single non-versioned shared object #4468
Comments
this looks a bit like PR #4252 ? (that I haven't had time to address properly yet) |
Yup, it seems so. Anything I can do to help move that one along? |
I hope to get to this now, with the other issues out of the way |
hmm, I'm slightly confused by your patch to openblas.pc.in
which I would have expected to be something like |
The prefix I am thinking of goes before openblas. So in my case, where |
I'm getting a feeling the makefiles have grown some unhealthy mix of automatic and manual prefix and suffix options lately. |
#4485 implements the basic idea but I still need to sort out the dual use of LIBPREFIX which is an internally generated variable already. (This also needs porting to cmake and integrating with the most recent realization from #3998 that symbol rewriting does not work when applied directly to a shared library ,as it is currently done in the cmake build) |
Over a few PRs to MacPython/openblas-libs, I changed the end result to be a Python wheel. This required packaging a single shared object with no symbolic links. I needed to
Here is the patch to OpenBLAS 0.3.26 to remove all the symlinking and versioning. Note the prefixing requires this line and this change in order to support prefixes in the pkg-config file. The rest of the patch is "just" removing things.
Would you be open to merging these changes, toggled with a build option, to reduce openblas-lib's maintenance burden?
The text was updated successfully, but these errors were encountered: