Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display note counts per instrument in song details #10

Open
Bentroen opened this issue Nov 13, 2024 · 0 comments
Open

Display note counts per instrument in song details #10

Bentroen opened this issue Nov 13, 2024 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@Bentroen
Copy link
Member

In the Songs page, by the 'Instruments' or 'Notes' attributes in the song stats display, show a question mark button as follows:
image

When clicked, this shows a modal similar to Note Block Studio's song stats, showing the number of note blocks per instrument (including custom instruments):
image

These stats are already calculated and stored in the database as part of the stats subdocument, and even already sent to the front-end server at render time. As such, implementing this is a matter of displaying them properly in the SongDetails component:
https://github.com/OpenNBS/NoteBlockWorld/blob/main/web/src/modules/song/components/SongDetails.tsx#L101-L113

Alternatively, instead of a modal, an expandable/collapsible section may be added inline to the stats table, if it improves presentation.

@Bentroen Bentroen added enhancement New feature or request good first issue Good for newcomers labels Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant