Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework version number management #144

Open
meekee7 opened this issue Oct 7, 2020 · 0 comments
Open

Rework version number management #144

meekee7 opened this issue Oct 7, 2020 · 0 comments

Comments

@meekee7
Copy link
Contributor

meekee7 commented Oct 7, 2020

The OpenTrespasser.exe binary has a manifest containing the executable version. Its content can be viewed via the file properties in Windows Explorer. This information can also be extracted by tools and scripts.
Currently, the version indicated in the manifest is based on data hardcoded in gblinc\Version.hpp.

The following improvements are proposed:

  • The version number is currently the same as vanilla Trespasser without the patch. It should instead be the OpenTrespasser version.
  • The version string should include the shortened Git hash.
    • A CMake script should generate a header file that contains the shortened Git hash.
    • It remains to be decided if the script should run only during CMake generation or during every compilation.
  • Ideally, all generated EXEs and DLLs should have a version manifest.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant