New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Uppercasing the geography code results in Geography not found exceptions #249

Open

adieyal opened this issue Apr 15, 2021 · 1 comment

Assignees

Contributor

adieyal commented Apr 15, 2021

wazimap-ng/wazimap_ng/datasets/dataloader.py

Line 16 in 21e1e63

geo_code = str(geo_code).upper()

Instead of uppercasing the code, we should match with the exact string from the dataset

Contributor

milafrerichs commented Apr 20, 2021

please also write a test with wrong code and correct geo codes

Geeker1 self-assigned this

Geeker1 mentioned this issue

Fix: Removed uppercasing on Geography code #254

Merged

15 tasks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment