Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why is the ffmpeg patch not already in ffmpeg master? #139

Open
thesn10 opened this issue Mar 14, 2021 · 6 comments
Open

Why is the ffmpeg patch not already in ffmpeg master? #139

thesn10 opened this issue Mar 14, 2021 · 6 comments
Labels
ffmpeg question Further information is requested

Comments

@thesn10
Copy link

thesn10 commented Mar 14, 2021

I can install SVT-AV1 without having to manually patch ffmpeg. So why isnt this the case with SVT-VP9 already?

@1480c1
Copy link
Member

1480c1 commented Mar 14, 2021

It requires a lot of effort and cleanup to upstream the patch and we do not have the resources and time to do so at this moment.

@tianjunwork tianjunwork added ffmpeg question Further information is requested labels Mar 14, 2021
@rathann
Copy link

rathann commented Apr 13, 2021

Looks like somebody asked about this 2 years ago already: https://trac.ffmpeg.org/ticket/7914 .

@joeyparrish
Copy link

I'm in the process of updating the patch for ffmpeg n6.0 now. I'll post a link here if I get it working. I had to make some adjustments that I'm not 100% certain about.

@joeyparrish
Copy link

I'm giving up for now. I got it to build, but I get this error:

[0911/173548:ERROR:demuxer.cc(202)] Failed to detect the container type from the buffer: 000000206674797069736F6D0000020069736F6D69736F3669736F326D703431

I don't get a similar error from SVT-AV1.

Here's the patch I'm using.
n6.0-0001-Add-ability-for-ffmpeg-to-run-svt-vp9.patch.txt

My guess is that I messed up the changes to the mkv_write_block() calls. That function changed so much that I was really not sure I was mapping the changes in the patch correctly.

@joeyparrish
Copy link

This simplified version has the same issue:

n6.0-0001-Simplified-libsvtvp9.patch.txt

I hope these are a useful starting point for someone who knows more than me about SVT-VP9 and FFmpeg both.

@joeyparrish
Copy link

Oh, crap, I was starting from the patch at SVT-VP9 0.30, which has been revised since then. Disregard the above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ffmpeg question Further information is requested
Projects
None yet
Development

No branches or pull requests

5 participants