Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle scenario existing file but empty #72

Closed
goldyfruit opened this issue Apr 18, 2024 · 2 comments · Fixed by #77
Closed

Handle scenario existing file but empty #72

goldyfruit opened this issue Apr 18, 2024 · 2 comments · Fixed by #77
Assignees
Labels
bug Something isn't working
Milestone

Comments

@goldyfruit
Copy link
Member

The installer should check if the scenario file contains YAML data as for now an empty scenario file triggers the ovos-installer to run non-interactive.

@goldyfruit goldyfruit added the bug Something isn't working label Apr 18, 2024
@goldyfruit goldyfruit added this to the Quake milestone Apr 18, 2024
@goldyfruit goldyfruit self-assigned this Apr 18, 2024
@suvanbanerjee
Copy link
Contributor

suvanbanerjee commented Apr 18, 2024

@goldyfruit Can i work on this issue ?

I am thinking to create a validate.sh file that will use regex to validate the correctness of config.yaml

@goldyfruit
Copy link
Member Author

goldyfruit commented Apr 18, 2024

I am thinking to create a validate.sh file that will use regex to validate the correctness of config.yaml

No need to add complexity, the scenario logic is already there, just few missing things.
Have a look to the draft #73, still have to fix the BATS testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants