Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect link to "Setting up a development environment" #168

Closed
mverzilli opened this issue Mar 26, 2020 · 4 comments
Closed

Incorrect link to "Setting up a development environment" #168

mverzilli opened this issue Mar 26, 2020 · 4 comments

Comments

@mverzilli
Copy link

Repro:

  1. Head to https://docs.openzeppelin.com/cli/2.8/getting-started
  2. Click on "Setting Up a Development Environment" in the first TIP Box.

Expected: it navigates to https://docs.openzeppelin.com/learn/setting-up-a-node-project (I guess?)

Actual: it navigates to https://docs.openzeppelin.com/cli/2.8/getting-started#learn::set-up-dev-environment, which results in reloading the same page.

@frangio
Copy link
Contributor

frangio commented Mar 26, 2020

Thanks for reporting!

Fixed in OpenZeppelin/openzeppelin-sdk@924aeee, and ported to the latest version in the site in OpenZeppelin/openzeppelin-sdk@4e61ae2.

@frangio frangio closed this as completed Mar 26, 2020
@mverzilli
Copy link
Author

I think the issue is more pervasive, probably I just stumbled upon an instance of this: #142

Here's another example: https://docs.openzeppelin.com/cli/2.8/publishing-ethereum-package#learn::public-staging.adoc

@frangio
Copy link
Contributor

frangio commented Mar 27, 2020

It may be pervasive because of the recent documentation refactoring we did, where it seems we missed updating several links. Because of #142 we haven't detected them automatically but I just thought of a way to find them all so I'll try that as soon as I can. In the meantine, if you want, feel free to submit patches to the docs!

@frangio
Copy link
Contributor

frangio commented Mar 27, 2020

I'm in the process of fixing most of these.

OpenZeppelin/openzeppelin-sdk#1517
OpenZeppelin/openzeppelin-contracts#2153

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants