-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean code comments in macro expansion (from templates) #24
Comments
Hi @4meta5, I can help with this. Just to make sure we need to address the inline documentation as mentioned in this comment. Also, do you want me to wait for you to merge the existing changes in #1 before proceeding with this? Thanks! |
Hi @mittal-parth! |
Alright noted. I’ll wait :) |
Hi @KitHat! I think this issue can be closed now seeing that the changes have been implemented in this commit? |
@mittal-parth This issue relates to cleaning the code comments in the grouping macro expansions, not adding docs to the top of each file (which was done in that commit). So I think it is still open -- for example #1 (comment) was not addressed in #1 |
Looks good to me so far @mittal-parth , added some comments but will approve once the same is done for the other groupings. |
Raised during review of #1
The text was updated successfully, but these errors were encountered: