Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐞 [Bug]: Usage of depreciated CurrencyAdapter in transaction_payment #251

Open
3 tasks done
KitHat opened this issue Jul 19, 2024 · 1 comment · May be fixed by #253
Open
3 tasks done

🐞 [Bug]: Usage of depreciated CurrencyAdapter in transaction_payment #251

KitHat opened this issue Jul 19, 2024 · 1 comment · May be fixed by #253
Assignees
@4meta5
Labels
bug Something isn't working on hold Pending other work or discussion

Comments

@KitHat
Copy link
Member

KitHat commented Jul 19, 2024

templates

  • Generic Runtime Template
  • Evm Template

What happened?

The runtime configuration for pallet_transaction_payment relies on deprecated (since v1.6.0) CurrencyAdapter [16]. The discrepancy this introduces may result in unexpected behavior and inconsistencies when calculating transferable balances.

Expected behavior

We recommend migrating to the supported FungibleAdapter and Fungible traits.

Contribution Guidelines

  • I agree to follow this project's Contribution Guidelines
@KitHat KitHat added the bug Something isn't working label Jul 19, 2024
@4meta5 4meta5 self-assigned this Jul 20, 2024
@4meta5 4meta5 linked a pull request Jul 20, 2024 that will close this issue
Open
@4meta5
Copy link
Contributor

4meta5 commented Jul 20, 2024

Blocked until we upgrade dependencies to include pallet_transaction_payment::FungibleAdapter in the dependencies

Checked and our current pinned commit for polkadot-sdk does not include the suggested config type pallet_transaction_payment::FungibleAdapater

@4meta5 4meta5 added the on hold Pending other work or discussion label Jul 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@4meta5 4meta5

Labels
bug Something isn't working on hold Pending other work or discussion
Projects
Substrate Runtime Templates
Status: ⚠ Blocked
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

CurrencyAdapter -> FungibleAdapter OpenZeppelin/polkadot-runtime-templates
2 participants
@KitHat @4meta5