Indexing Providers: Unit Tests

[Skrypt]

The Lucene unit tests are not covering all use cases.
We are missing unit tests for the LuceneIndexingContentHandler and all the events that are possible.

1. Create a content item.
2. Publish a content item.
3. Save a draft of a content item.
4. Remove a content items.

The "index latest" option of a Lucene index needs also to be unit tested against all these events.

[Piedone]

How about the same for Elasticsearch?

[hyzx86]

It looks like we can't test the Created function alone
In my tests, they are not even saved to the database.

    await contentManager.CreateAsync(firstContent);
    var contentFromDb = await contentManager.GetAsync(firstContent.ContentItemId);
    Assert.NotNull(contentFromDb);

[hishamco]

Why?

[hyzx86]

You can try this PR~~

https://github.com/OrchardCMS/OrchardCore/pull/13721/files#r1587500147

Comment part of the code, cannot pass

[hyzx86]

We have to create content like this

                await contentManager.UpdateValidateAndCreateAsync(firstContent, VersionOptions.Draft);
                await contentManager.PublishAsync(firstContent);
                var contentFromDb = await contentManager.GetAsync(firstContent.ContentItemId);
                Assert.NotNull(contentFromDb);

[hishamco]

I will have a look if I have a time

[hyzx86]

Without calling PublishAsync, we wouldn't even be able to find it from the database

[hishamco]

This is a unit test, right? no database interaction

[hyzx86]

Indeed in unit testing,
The test context is BlogContext, which should use the Sqlite database.
If I call PublishAsync, then this object can be retrieved from the database

[github-actions]

We triaged this issue and set the milestone according to the priority we think is appropriate (see the docs on how we triage and prioritize issues).

This indicates when the core team may start working on it. However, if you'd like to contribute, we'd warmly welcome you to do that anytime. See our guide on contributions here.