Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent Displaying events from being called when a shape is cached #16681

Open
sebastienros opened this issue Sep 6, 2024 · 1 comment
Open
Assignees
Milestone

Comments

@sebastienros
Copy link
Member

c.f. #16677

Ideally the lambda passed to a driver in the initializing argument should not be called when caching is kicking in. But then we need a new event such that caching can happen BEFORE "displaying", which we don't have. And maybe two more events: one to initialize, such that "displaying" events know that the object has the properties it requires, and one before that such that "caching" can prevent initialize to happen.

Another options, which would not require new events or breaking changes is that after the IShapeDisplayEvents.DisplayingAsync invocations, we check if the ChildContent has been set and skip other DisplayingAsync event (called by the drivers and shape descriptors). Processing would then be useless.

@sebastienros sebastienros self-assigned this Sep 6, 2024
@sebastienros sebastienros added this to the 2.x milestone Oct 3, 2024
Copy link
Contributor

github-actions bot commented Oct 3, 2024

We triaged this issue and set the milestone according to the priority we think is appropriate (see the docs on how we triage and prioritize issues).

This indicates when the core team may start working on it. However, if you'd like to contribute, we'd warmly welcome you to do that anytime. See our guide on contributions here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant