Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recipe step -> OpenIdServerSettings -> AccessTokenFormat doesn't work #16879

Closed
hieucd04 opened this issue Oct 13, 2024 · 9 comments · Fixed by #16913
Closed

Recipe step -> OpenIdServerSettings -> AccessTokenFormat doesn't work #16879

hieucd04 opened this issue Oct 13, 2024 · 9 comments · Fixed by #16913
Assignees
Milestone

Comments

@hieucd04
Copy link

Describe the bug

Recipe step -> OpenIdServerSettings -> AccessTokenFormat doesn't work!

Orchard Core version

2.0.2

To Reproduce

Steps to reproduce the behavior:

  1. Go to https://docs.orchardcore.net/en/main/reference/modules/OpenId/
  2. Search for AccessTokenFormat (see image below)

What happened

The docs said that AccessTokenFormat can be set to value "JsonWebToken". However, it didn't work. Instead, I had to set it to 1. I suspect there is a Json deserialization issue involving C# enum.

Expected behavior

Either Recipe step -> OpenIdServerSettings -> AccessTokenFormat works as the docs said or the docs needs to be updated.

bug

@Piedone
Copy link
Member

Piedone commented Oct 13, 2024

This looks like a JSON serialization issue, no @MikeAlhayek?

@Piedone Piedone added the OpenId label Oct 13, 2024
@hishamco
Copy link
Member

@hieucd04 could you please try it on the nightly build, I came across this issue a few days ago, and I hope it got fixed, otherwise let us know

@MikeAlhayek
Copy link
Member

I think this is a serializer option. We don't include a two way enum converter.

@MikeAlhayek
Copy link
Member

I came across this issue a few days ago, and I hope it got fixed, otherwise let us know

@hishamco what did you do to fix this issue?

@hishamco
Copy link
Member

Let me first check if I can reproduce the issue in the nightly build

@sebastienros sebastienros added this to the 2.x milestone Oct 17, 2024
Copy link
Contributor

We triaged this issue and set the milestone according to the priority we think is appropriate (see the docs on how we triage and prioritize issues).

This indicates when the core team may start working on it. However, if you'd like to contribute, we'd warmly welcome you to do that anytime. See our guide on contributions here.

@sebastienros
Copy link
Member

I assume we can add this option if it's available.

@hishamco hishamco self-assigned this Oct 17, 2024
@hieucd04
Copy link
Author

@hishamco I tried to look for prerelease versions of OrchardCore.* nuget packages to install but couldn't find any.
Let me know if you need any other info on this. I think I can help test this issue on my side but I need the version-to-be-tested to be available on nuget.

@hishamco
Copy link
Member

Thanks, I hope to find time today to revisit this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants