Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Constitution score uses Caduceus instead of Rod of Asclepius for imagery #602

Closed
TechyShishy opened this issue Feb 18, 2024 · 2 comments · Fixed by #604
Closed

Constitution score uses Caduceus instead of Rod of Asclepius for imagery #602

TechyShishy opened this issue Feb 18, 2024 · 2 comments · Fixed by #604

Comments

@TechyShishy
Copy link

Describe the bug
The little icon above Constitution scores uses a symbol known as a Caduceus, rather than the medically relevant Rod of Asclepius. This is a common misconception (see: https://en.wikipedia.org/wiki/Caduceus_as_a_symbol_of_medicine), but Orcpub would benefit from using the correct symbol

Screenshots

Screenshot from 2024-02-18 07-18-23

Desktop (please complete the following information):

  • OS: Linux
  • Browser: Chrome
  • Version: 121.0.6167.184
@codeGlaze
Copy link

lol this might just be a limit to the icon library we use.
I'll take a look ;)

codeGlaze added a commit to codeGlaze/orcpub that referenced this issue Mar 11, 2024
@codeGlaze
Fixes Orcpub#602 - minor - SVG icon swap
5dc7f02 
minor
+ adds svg icons for rod-of-asclepius
+ changes CON icon to RoA
+ added some basic documentation to relevant functions
@codeGlaze codeGlaze mentioned this issue Mar 11, 2024
Merged
5 tasks
@codeGlaze
Copy link

Ha, apparently a duplicate of #573 too

datdamnzotz added a commit that referenced this issue Mar 28, 2024
@datdamnzotz
Merge pull request #604 from codeGlaze/602-fix-icon-asclepius-svg
d57501d 
Fixes #602, #573 icon asclepius svg
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes #602, #573 icon asclepius svg codeGlaze/orcpub
2 participants
@TechyShishy @codeGlaze