Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Submitting a proposal without signature can break the proposal page #354

Open
ivanzhelyazkov opened this issue Oct 19, 2022 · 0 comments
Open
Labels
bug Something isn't working good first issue Good for newcomers P2 Small number of users are affected, major cosmetic issue

Comments

@ivanzhelyazkov
Copy link
Contributor

There are two functions supported for submitting proposals using the OUSD governance system:

function propose(
        address[] memory targets,
        uint256[] memory values,
        bytes[] memory calldatas,
        string memory description
    )
function propose(
       address[] memory targets,
       uint256[] memory values,
       string[] memory signatures,
       bytes[] memory calldatas,
       string memory description
   ) 

Submitting a proposal using the first method may break the proposal page because the FE relies on the signature to exist in order to read the proposal data. Example of that on staging:
https://ousd-governance-goerli.herokuapp.com/proposals/16204839399612801854620380292150922398934072453886132313980681190386539950238
Proposals without signatures could be read as invalid by the FE, or could skip the call data validation part.

@sparrowDom sparrowDom added bug Something isn't working P2 Small number of users are affected, major cosmetic issue good first issue Good for newcomers labels Oct 19, 2022
@micahalcorn micahalcorn moved this from Backlog to To-do in Origin DeFi (OUSD + OETH) Jan 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers P2 Small number of users are affected, major cosmetic issue
Projects
Status: To-do
Development

No branches or pull requests

2 participants