Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reliable contributors data #48

Closed
micahalcorn opened this issue Oct 31, 2022 · 9 comments
Closed

Reliable contributors data #48

micahalcorn opened this issue Oct 31, 2022 · 9 comments
Assignees
Labels
bug Something isn't working P1 Large amount of significant user impact, a meaningful feature is broken planned In-scope at the beginning of the sprint
Milestone

Comments

@micahalcorn
Copy link
Member

The GitHub contributors data often doesn't load.

image

@micahalcorn micahalcorn added bug Something isn't working P1 Large amount of significant user impact, a meaningful feature is broken labels Oct 31, 2022
@rolandpo
Copy link
Contributor

fix is up to at least hide the '0 open-source contributors' when not loaded, not yet deployed

@micahalcorn
Copy link
Member Author

fix is up to at least hide the '0 open-source contributors' when not loaded, not yet deployed

Thanks, what's the underlying issue here?

@rolandpo
Copy link
Contributor

there's a lot of calls going on to get contributors from multiple repositories so might be going over the API limit, might have to add some access token to the request

@micahalcorn
Copy link
Member Author

there's a lot of calls going on to get contributors from multiple repositories so might be going over the API limit, might have to add some access token to the request

Would it make sense for us to just store the information in our db and then update it periodically with a cron job or something?

@joshfraser
Copy link

We already built a script to pull and cache this on the python stack. Perhaps we serve the data from the API instead?

@rolandpo
Copy link
Contributor

oh yeah good call, I'll look into it in a bit

@micahalcorn micahalcorn moved this from Backlog to To-do in Origin DeFi (OUSD + OETH) Nov 12, 2022
@micahalcorn micahalcorn moved this from To-do to In progress in Origin DeFi (OUSD + OETH) Dec 5, 2022
@rolandpo
Copy link
Contributor

rolandpo commented Dec 7, 2022

related PR:
OriginProtocol/origin-website#651

@micahalcorn micahalcorn added this to the Sprint 41 milestone Dec 8, 2022
@micahalcorn micahalcorn added the planned In-scope at the beginning of the sprint label Dec 8, 2022
@micahalcorn micahalcorn modified the milestones: Sprint 41, Sprint 42 Dec 26, 2022
@rolandpo
Copy link
Contributor

I believe this is fixed with fddaa00

@franckc
Copy link

franckc commented Dec 29, 2022

marking as done. nice work @rolandpo

@franckc franckc closed this as completed Dec 29, 2022
@github-project-automation github-project-automation bot moved this from In progress to Done in Origin DeFi (OUSD + OETH) Dec 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working P1 Large amount of significant user impact, a meaningful feature is broken planned In-scope at the beginning of the sprint
Projects
Status: Done
Development

No branches or pull requests

4 participants