Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regular null reference exceptions #35

Open
BogdanovKirill opened this issue Jul 5, 2022 · 1 comment
Open

Regular null reference exceptions #35

BogdanovKirill opened this issue Jul 5, 2022 · 1 comment

Comments

@BogdanovKirill
Copy link

It seems you should inspect all methods that you call at StackExchange.Redis. For example:

RedisValue[] values = await _db.SortedSetRangeByValueAsync(RemindersRedisKey, from, to);
if (values.Length == 0)

Wrapper could return null and you will get NRE. That's very bad.

Check here:

Orleans.Redis/src/Orleans.Reminders.Redis/RedisReminderTable.cs

Line 63 in ecc5cfa

if (values.Length == 0)

@BogdanovKirill
Copy link
Author

Any news? Should I make pull request for you?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@BogdanovKirill