Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auth/refresh always returns tokens with maximal expiery time #90

Open
BotatoPeel opened this issue Dec 6, 2024 · 3 comments
Open

auth/refresh always returns tokens with maximal expiery time #90

BotatoPeel opened this issue Dec 6, 2024 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@BotatoPeel
Copy link

/auth/refresh endpoint returns tokens with expierydate 30 days into the future no matter what is passed in the expiresInMins parameter.
Looking at the code i suspect the issue is that expiresInMins is not passed on to the tokengeneratormethod(s) in line 82 and 83 of auth.js

@Ovi Ovi added the bug Something isn't working label Dec 18, 2024
@Ovi Ovi self-assigned this Dec 18, 2024
@CseHitesh
Copy link

Hi, could you please assign this issue to me? I would like to work on it.

@Ovi Ovi assigned CseHitesh and unassigned Ovi Jan 7, 2025
@Ovi
Copy link
Owner

Ovi commented Jan 7, 2025

Thank you @CseHitesh!
Done 👍

@CseHitesh
Copy link

Hi @Ovi, 👋

I've submitted a PR to fix the issue with token expiration in /auth/refresh by correctly passing the expiresInMins parameter and setting a default of 60 minutes as per the documentation: #94.

Could you please review and merge it when you get a chance? Let me know if there are any changes or improvements you'd like me to make!

Thank you for your time and for maintaining this awesome project! 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants