Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove bootstrap dependency #1

Open
jamiechong opened this issue Aug 1, 2018 · 1 comment
Open

Remove bootstrap dependency #1

jamiechong opened this issue Aug 1, 2018 · 1 comment

Comments

@jamiechong
Copy link

It would be great if this component implemented its own CSS styles and didn't depend on Bootstrap.

@Owumaro
Copy link
Owner

Owumaro commented Aug 7, 2018

I agree on this, however I would like to keep this "bootstrap-compatible".

For example, if someone is using bootstrap with custom variables, the plugin should use its rules.

I thought about copying/pasting bootstrap rules that I use in this plugin, however this would override custom bootstrap from the app.
I could use scoped css to avoid this, but by doing, custom bootstrap css in the app won't apply to the component.

I don't know if there is a best practice for this issue, if you think of something let me know :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants