Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support TwistWithCovarianceStamped #15

Open
JonasHablitzel opened this issue Apr 17, 2023 · 5 comments
Open

Support TwistWithCovarianceStamped #15

JonasHablitzel opened this issue Apr 17, 2023 · 5 comments

Comments

@JonasHablitzel
Copy link

Hi,

i wanted to ask if there is any plan to publish TwistWithCovarianceStamped instead of TwistStamped for the ins/velocity Topic, similar to the ROS1 driver?

@ljones-oxts
Copy link
Contributor

Hi Jonas

There are no plans at the moment to publish TwistWithCovarianceStamped - part of the issue is that the angular rate covariances are not actually stored in our NCOM format.

I can raise the issue internally if this is something that is causing you issues.

Thanks

Llyr

@JonasHablitzel
Copy link
Author

Hi Llyr,

thank for the quick response, we plan to use the OXTS together with the Autoware stack. As Autoware expects TwistWithCovarianceStamped an adaptation would be neccesary. Do you think an implementation of the usecase on the ROS-Driver Side would be also possible? So we could avoid an adaptation of the NCOM format?

@marioney
Copy link

We're facing this same issue. We worked around by changing the topic type and setting a fixed value for the covariance, but of course the correct value for the is still missing.

@JonasHablitzel did you find a different solution for this?
@ljones-oxts Has there been any progress for this.

@ljones-oxts
Copy link
Contributor

Hi @marioney and @JonasHablitzel

My apologies for neglecting this thread. Having discussed with my colleagues, we are unable to provide the actual covariance measurements for twist (due to internal IP concerns). However, would your tool be able to accept a TwistWithCovarianceStamped message even if the covariance entries are set to zeroes (or some other dummy value)?

Thanks

Llyr

@marioney
Copy link

marioney commented Nov 16, 2023

Thanks for your response @ljones-oxts

I think it should work with dummy covariance value, zeroes may not be the best option, I'd prefer to use a fixed "average" covariance value, or maybe something that can be configured by a parameter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants