Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Perf] [Bug] Figure out why first fetch during parsing doesn't always give all objects, refactor #26

Open
thomassnielsen opened this issue Dec 21, 2014 · 3 comments
Assignees

Comments

@thomassnielsen
Copy link
Member

This is a particularly nasty bug that most likely causes most of the current issues of TSNREST, including duplicates. Sometimes when fetching from the local store, there will be some objects that doesn't load, and we have to load them individually later in the parsing process to avoid duplicates. There must be some way to avoid this.

@thomassnielsen
Copy link
Member Author

One of the problems we face is that there may be new objects added to the store during parsing, but that can't account for every time this happens, it's way to often. We may need to go back to parsing on a serial queue though, to avoid these issues entirely.

@thomassnielsen
Copy link
Member Author

I'll be much more comfortable fixing this when we've got tests in place and have refactored more of the related code. It's too volatile right now, and I feel we've gotten new bugs for every one we fix.

@thomassnielsen thomassnielsen self-assigned this Dec 21, 2014
@thomassnielsen
Copy link
Member Author

By fixing #40 I think this might be better, if not entirely fixed. Using @synchronized or going to a serial queue might be needed to fix this entirely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant