Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving generality and speed of newly-ported MESA code #47

Open
11 tasks
nriemer opened this issue Aug 5, 2024 · 0 comments
Open
11 tasks

Improving generality and speed of newly-ported MESA code #47

nriemer opened this issue Aug 5, 2024 · 0 comments
Assignees

Comments

@nriemer
Copy link
Collaborator

nriemer commented Aug 5, 2024

  • Check if Taylor-expansion coefficients can be replaced by yaml files
  • Check if hard-coded Taylor-expansions multiplies can be replaced by matrix operations.
  • Relax hardcoded species indices
  • Figure out where the hardcoded liquid-liquid temperature-dependent thermodynamic parameters come from
  • Reevaluate solid and liquid phases separately (aerosol and electrolyte; e.g., aero can be a view of 1D liquid first and then solid)
  • compute_activities (maybe other functions) need aerosol state, phase, and hysteresis leg set beforehand, so make sure these are carried correctly
  • Consider adding update_thermodynamic_constants instead of directly computing constants within compute_activities (making sure that temp. is handled)
  • Fix duplicated code to handle Fortran go to statements
  • Check to make sure that the activity of water is being updated with relative humidity (i.e., aH20 should not be local in bin_molality and fnlog_gamZ)
  • Fix hardcoded tolerance for ASTEM
  • Make sure aerosol_water_total is an input where necessary and not hardcoded (e.g., in team_invoke)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants