Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Domain definition for Monsoon Wang's NAFM #820

Closed
lee1043 opened this issue Nov 20, 2021 · 3 comments · Fixed by #1200
Closed

Domain definition for Monsoon Wang's NAFM #820

lee1043 opened this issue Nov 20, 2021 · 3 comments · Fixed by #1200
Assignees
Labels

Comments

@lee1043
Copy link
Contributor

lee1043 commented Nov 20, 2021

Found by @pochedls at xCDAT/xcdat#166 (comment).


The NAFM region in monsoon_wang driver is for North African Monsoon, 310E to 60E (as in below figure).

a-Map-showing-the-positions-and-aerial-extent-of-monsoons-as-defined-by-the(image from here)


However, with region defined as longitude=(310, 60), the area considered is from 60E to 310E (mirrored, as in below figure).

NAFM

import cdms2
import vcs
f = cdms2.open('CanCM4_NAFM_wang-monsoon.nc')
d = f('variable_993')
x = vcs.init()
x.png('NAFM.png')

In the PMP's driver for the Monsoon Wang metric, it opens model file with regular cdms2 open, as f = cdms2.open(modelFile).

@gleckler1 Could you point the reference paper for the Monsoon Wang index? And any idea for quick fix?

@gleckler1
Copy link
Collaborator

@lee1043
Copy link
Contributor Author

lee1043 commented Sep 6, 2024

Note: This issue should be resolved by using the new regions_subset function.

@bosup is working on xcdat migration of monsoon Wang code and will test this function in the monsoon Wang (related discussion: xCDAT/xcdat#692).

@lee1043 lee1043 linked a pull request Nov 26, 2024 that will close this issue
@lee1043
Copy link
Contributor Author

lee1043 commented Nov 26, 2024

Screenshot 2024-11-26 at 1 03 18 PM
The above screenshot from ncview CanCM4_NAFM_wang-monsoon.nc where the file is from Demo 2a notebook from PR #1200 confirms that the issue will be resolved by merging the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants