Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom projectile cooldown not respected after switching teams #1285

Closed
willocn opened this issue Dec 17, 2023 · 2 comments
Closed

Custom projectile cooldown not respected after switching teams #1285

willocn opened this issue Dec 17, 2023 · 2 comments

Comments

@willocn
Copy link

willocn commented Dec 17, 2023

When you switch teams during a match, projectile cooldown is not respected. Projectile works as expected if you switch back to the original team.

Steps to reproduce

  1. Join a team
  2. Switch teams
  3. Observe that you can shoot projectiles instantly

This doesn't happen on FFA matches.

team_swap_glitch.mp4
@Pugzy
Copy link
Contributor

Pugzy commented Dec 17, 2023

Caused by the following code which always sets the cooldown to be ended if the player team states don't match.

if (matchPlayer.isDead() || matchPlayer.getParty() != matchPlayerState.getParty())

Looks like cooldowns are stored for a player on each team they join but due to equal checks they always use the expired one.

@Pablete1234
Copy link
Member

Fixed in #1297

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants