Match stats longest shot seems inaccurate

[brendanfuller]

I've recently noticed that end game match stats only care about about the longest shots/sniped shots on land rather than shots that have death by void, or death by falling. All I'm wondering is should all bow shots count and not just land shots, assuming this is not intended.

Originally I thought it was due to the 60 block sniped vs shot but that doesn't seem to be the issue.

Though anyways here some evidence:

1. I kill someone with a great shot (these images are all from the same match)
   
2. The match ends, but its only the attacker who had the land shot (which is rounded up for some reason?)
   
3. Find said attacker, who got that "longest shot" in the chat, which was on land
   

Further more I wanted to see if this was common with every match I've played/spectated via the Minecraft logs.
So I create a simple python script to see said information:

Out of 432 games which have the Match Stats shown, only 112 of them were actually accurate, and 106 of them were all land shots only.

For anyone interested here's the the outputted data from said python script here ya go matches.txt

[KingOfSquares]

Oh yeah thats not intended but its something i never found the reason for when i initially made it.

[Pugzy]

I though the falling/void deaths included the distance the person fell too? This would make them inaccurate as the arrow doesn't actually hit at that range.

[Pablete1234]

Match stats is what is accurate, it's the distance the arrow traveled, kill message however, is distance from killer to victim at their time of death, so if you knock them out of the world all the height they fall is added up

[CoWinkKeyDinkInc]

Fixed

[Pablete1234]

Fixed

Could you reference the commit/pr that fixed it? If you mean #897 it only fixed one (small) issue, but not the big difference

[Pugzy]

Could you reference the commit/pr that fixed it? If you mean #897 it only fixed one (small) issue, but not the big difference

Unless scenarios like 'sniped out of the world' are updated to only be the distance the arrow flew I don't think they should be considered longest shots.

[Pablete1234]

Unless scenarios like 'sniped out of the world' are updated to only be the distance the arrow flew I don't think they should be considered longest shots.

Yeah, the fix is to modify the sniped out of the world message to only include how long your snipe was, not how far they fell after you sniped them. Should be distance between shooting point and impact on the attacker, like match stats are properly reporting

[Pugzy]

The changes made in #897 and #1272 should both resolve this discrepency.